Cannot publish to Gitlab pages when using image links

Alvenster

I'm building a portfolio website, so I need to have lots of images and videos.
I figured I would try to not upload EVERYTHING since it can be heavy and most of it is already uploaded to Artstation, so I decided to use links to Artstation for my images literally copying the image link and pasting into Silex, and it works inside of the editor but not when trying to publish. I got this error :
An error occured, your site is not published. Error publishing the website. GitLab raw file not found: filePath="assets/https:/cdna.artstation.com/p/assets/rest-of-the-image URL

I'm guessing Gitlab tries to interpret the image url as a filepath and therefore it doesn't work ? Are image links supported in Gitlab ??
Plz help 😢

lexoyo

I have fixed the issue, but in the published site, there will be your URLs as you provided them. I mean, silex could download them and serve them from gitlab pages. Not sure if that would be better

Anyway, this will be live soon for you to test Alvenster

lexoyo

Hello
Thanks for reporting this. You're right — Silex is currently trying to download external images and save them as local assets when publishing
Let me investigate and come back to you tomorrow

lexoyo

Here is the fix
https://github.com/silexlabs/silex-lib/commit/658272ee7ed57629d83ffd17a4a1af3bc834cd94

Most of it are tests to make sure it is fixed forever

lexoyo

it's live on canary.silex.me

Can you refresh without cache and confirm the bug is fixed? you might have to reimport the images, maybe not

Alvenster

Sorry I did not come back to the forum, as I had fixed the issue by just uploading the images myself. I'll test this and tell you if it worked 🙂