Background image does not load

jschilli

I'm using silex https://v3.silex.me/en/.
I try to create a page with an background image. Everything seems to woork in the editor, but as soon as I publish the page the image is gone.
I found out that the css files misses a quotation mark:

...background-image:url(../assets/xxxxxx.jpg?xxxx=gitlab')...

So, the first quotation mark is missing.
I guess this is a bug. My question is how I can avoid correcting the css files each time I publish changes. Is there a way to have a correction lasting for the next publish event?

Thank you!

lexoyo

hello
i'd like to see the online version please, did you publish it online?
also maybe post here the gitlab project, just in case i need to investigate more

lexoyo

I guess this is a bug. My question is how I can avoid correcting the css files each time I publish changes. Is there a way to have a correction lasting for the next publish event?

well silex has to override the css because you change the styles in the editor right?

the best way would be that i fix it today and you can continue working tomorrow 🙂

Jeaan-phi

Hi lexoyo

I confirm this bug in Silex, for my part I even encounter the problem in Silex my bg are no longer visible and even by deleting the gb and replaying the bg.

You have to recreate a container so that the bg is visible in the work area.

Not cool, because I have to deliver my site next week.

jschilli

Thank you so much for this very fast reply!
You are right: I had to edit it in the CSS file directly and silex has to override it.

Here is the online-version: osterweg-gomaringen.de

Thanks again!

lexoyo

I'm on it

lexoyo

Ok I found out that it is a bug only for images with space in the name, e.g. abc.jpg works fine but a b c.jpg doesn't work after publication when put as a bg image

I will fix this soon, but as a workaround you can remove the spaces in the image names or add your images with an image block instead as a bg image

I'll keep you posted when it is fixed

PS: I will ask you to test new versions on canary.silex.me soon, this is important to avoid such problems in production, thx

lexoyo

Fixed with this code
https://github.com/silexlabs/silex-lib/pull/4

I have deployed the fix on canary, please help check it didn't break anything else, especially dealing with publication and css
https://canary.silex.me

(you don't need workaround if it works)

jschilli

Hi @lexoyo,
Thank you very much for this fix! I will test it tonight.
Regards!

jschilli

Hi @lexoyo
Here is my test result:
1.) on one of my pages the fix works. I checked the css file and recognized that the quotation mark ' was replaced by quotation mark ".
2.) on the sub pages the fix did not work. Checking the css files shows that the issue is cause probably by a file name containing brackets. I recognized as well that the quotation mark type has been changed - but somehow the former version ' is still present. Please have a look to this css snippit (I marked my findings)

{ box-sizing: border-box; } body {margin: 0;}#ie1cf{background-color:rgba(0,0,0,0.22);background-repeat:no-repeat;background-position:left top;background-attachment:scroll;background-size:cover;background-image:url("../assets/ONE - Osterweg Slide (6").jpg?websiteId=66290475&connectorId=gitlab');}#iipys{display:flex;}#io9cj{display:flex;justify-content:space-evenly;min-width:120px;width:100%;}#i72al{padding:10px;align-self:flex-start;min-width:120px;text-align:center;font-family:"Caveat",

I will now test filenames without brackets and spaces.

Thank you

jschilli

Using image file names without brackets and spaces works great,
I will go this way until it is fixed.

Thanks again for your great help!

lexoyo

Ok thank you for the tests, it's very useful

Jeaan-phi

lexoyo

I'm going back to the topic, because Silex always breaks bg images.
Under the language selection bar, it should have 4 containers with images.

Here's a link.

https://silex-francecomsante-066983.gitlab.io/

lexoyo

Oh ok I'll check this out thx
Can you confirm that you used canary.silex.me to publish?

Jeaan-phi

lexoyo

I did use Canary for publishing.

lexoyo

I'm sorry but i can't find the 4 containers with images 🙁

Jeaan-phi

I've re-published, the containers are visible on the Internet, but not in Silex.